-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap LLD into python #898
base: main
Are you sure you want to change the base?
Wrap LLD into python #898
Conversation
This fixes the following link errors: .../miniconda3/envs/build/conda-bld/lld_1542237425154/_build_env/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: ../../lib/liblldCOFF.a(MapFile.cpp.o):(.data.rel.ro._ZTIN4llvm13format_objectIJmmmEEE[_ZTIN4llvm13format_objectIJmmmEEE]+0x10): undefined reference to `typeinfo for llvm::format_object_base'
For now we just call lld::elf::link.
This is a temporary workaround to get it working. We have to figure out how to obtain these automatically.
Many thanks for opening this PR! |
Okay, going to try a different approach. I'm going to see if I can rebuild the conda recipe for lld. I think that would ensure that they are both compiled using the same set of libraries and what not. Idk if its gonna work, but its worth a shot at least once right? |
I got it working! Finally! Now it just needs review. And I work from home now so feel free to contact me thru here if you all need to me to modify anything or fix anything for the next update. |
@ArachnidAbby this is "pretty dope" -- I much appreciate the attention to detail and your INSANE level of persistence. I was just able to skim in this current session, what hints would you have for the reviewers? Is there anything specific I could test or try or should I look out for something? |
@ArachnidAbby I ran this through the Anaconda internal "build farm" and this fails to compile on
|
@esc Thats really odd that it does that. Does this run all of the same steps that the ci/cd pipeline does? Or does this run a different set of scripts? Because this same issue happened, and I thought I had fixed it in the ci/cd pipeline. So I'm a little confused edit: also, is this using llvm15 or 16? and from which channel? |
Not sure, probably very similar though. I do know however that the Azure pipelines don't run
This uses the |
really odd that this issue would occur. But if its llvm15 it makes sense that the fix I made for llvm16 wouldn't be applied (it only applied it for llvm16 but I assume it should work fine for llvm15). Surprised that the numba channel one isn't working tbh. I'm gonna try pushing a quick fix in a minute or two, and we can see if it works. |
Based on: Add dependency on LLD, wrap it into python
todo:
.binding.lld
module with functions for each platform lld supportsitems remaining in the original PR
(all non-required items are going to be checked off)
I will update you as I complete items.